Update Project Profile: Remove Gayle Martin from HackforLA.org Website #7720
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
There was a problem hiding this comment.
@katiejnete great job on this issue.
- The branch name is correct with the issue number
- The before and after screenshots are good as well.
- Title and description is very clear and concise
Things you need to fix
- You need to fix the merge conflict
Thank you for taking on this issue.
…: remove Gayle and Nayan
There was a problem hiding this comment.
Hi @katiejnete, Thanks for taking on this issue!
Things you did well:
- branch name contains issue #
- PR title and description sections are descriptive and succinct.
- Visual Changes are included
- Great job resolving the merge conflict!!!!
No changes needed, great job! Keep it up!
There was a problem hiding this comment.
Hi @katiejnete It looks like you previously resolved a merge conflict, and after you did that you re-requested a review from @codyyjxn - thanks! This is exactly the process to follow.
- Unfortunately, there is an additional merge conflict that just popped up due to merging 7718. Please resolve this one as well.
- Also, please check the appropriate box under "CodeQL Alerts"
- Then re-request a review from me and I will merge this
katiejnete
dismissed stale reviews from t-will-gillis and FamousHero
via
d0fb702
There was a problem hiding this comment.
Hi @katiejnete. Thanks for working on this. Branches, code changes and the what and why sections are correct. I couldn't observe the merge conflict that was commented before. It was probably fixed by your last changes removing Mario.
The changes look good in the local version of the website.
Well done!
There was a problem hiding this comment.
Hey @katiejnete Thank you for taking care of the merge conflict- a second time- and thanks for working on this. Looks great!
FYI For the "CodeQL Alerts", you can check the box that ends with "...and none were found." I changed it since you did not have one of those alerts. If you want to see what the CodeQL alert looks like, you can open the dropdown:
"> Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown"
@FamousHero and @codyyjxn Since you previously Approved this PR, I will go ahead and merge it.
t-will-gillis
dismissed
codyyjxn’s stale review
Dismissing because @katiejnete resolved the merge conflicts
Fixes #6981
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied